-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmetic updates from User Test 1 #377
Conversation
for more information, see https://pre-commit.ci
src/renderer/src/stories/pages/guided-mode/setup/GuidedNewDatasetInfo.js
Outdated
Show resolved
Hide resolved
src/renderer/src/stories/pages/guided-mode/setup/GuidedSubjects.js
Outdated
Show resolved
Hide resolved
src/renderer/src/stories/pages/guided-mode/setup/GuidedNewDatasetInfo.js
Outdated
Show resolved
Hide resolved
src/renderer/src/stories/pages/guided-mode/data/GuidedStructure.js
Outdated
Show resolved
Hide resolved
src/renderer/src/stories/pages/guided-mode/data/GuidedSourceData.js
Outdated
Show resolved
Hide resolved
Overall I really like this improvement; current suggestions are all related to how to phrase these descriptors for maximum effect Also, the inspector and preview pages do not seem to have descriptions; we should add some to those too "The NWB Inspector has scanned your files for adherence to the Best Practices" (if you can add hyperlinks to the text, feel free to link 'Best Practices' to https://nwbinspector.readthedocs.io/en/dev/best_practices/best_practices_index.html) "Preview file contents on truncated files using the Neurosift application\nNeurosift can also be run directly on the full files once uploaded to DANDI, or on any file available on your local system" |
I'd also say the final DANDI upload page (the summary report) is rich enough to not need a description on its own |
@CodyCBakerPhD Alright updated based on your suggestions! |
Looks great! |
This PR implements a set of cosmetic updates from User Test 1—specifically the inclusion of subtitles to indicate page purpose.