Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic updates from User Test 1 #377

Merged
merged 6 commits into from
Sep 26, 2023
Merged

Cosmetic updates from User Test 1 #377

merged 6 commits into from
Sep 26, 2023

Conversation

garrettmflynn
Copy link
Member

This PR implements a set of cosmetic updates from User Test 1—specifically the inclusion of subtitles to indicate page purpose.

@CodyCBakerPhD
Copy link
Collaborator

Overall I really like this improvement; current suggestions are all related to how to phrase these descriptors for maximum effect

Also, the inspector and preview pages do not seem to have descriptions; we should add some to those too

"The NWB Inspector has scanned your files for adherence to the Best Practices" (if you can add hyperlinks to the text, feel free to link 'Best Practices' to https://nwbinspector.readthedocs.io/en/dev/best_practices/best_practices_index.html)

"Preview file contents on truncated files using the Neurosift application\nNeurosift can also be run directly on the full files once uploaded to DANDI, or on any file available on your local system"

@CodyCBakerPhD
Copy link
Collaborator

I'd also say the final DANDI upload page (the summary report) is rich enough to not need a description on its own

@garrettmflynn
Copy link
Member Author

@CodyCBakerPhD Alright updated based on your suggestions!

@CodyCBakerPhD
Copy link
Collaborator

Looks great!

@CodyCBakerPhD CodyCBakerPhD merged commit 02a2925 into main Sep 26, 2023
@CodyCBakerPhD CodyCBakerPhD deleted the user-testing-1 branch September 26, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants